Resolve localhost dns #665
Merged
+47
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divolgin
approved these changes
Jan 13, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| TLSHandshakeTimeout: 10 * time.Second, | ||
| ExpectContinueTimeout: 1 * time.Second, | ||
| }, | ||
| } |
There was a problem hiding this comment.
Custom HTTP transport loses proxy environment variable support
Medium Severity
The custom http.Transport doesn't set the Proxy field, which defaults to nil. Previously, the code used http.DefaultClient which uses http.DefaultTransport with Proxy: http.ProxyFromEnvironment. This means environment variables like HTTP_PROXY, HTTPS_PROXY, and NO_PROXY are now ignored for all requests, not just .localhost ones. Users behind corporate proxies or in environments requiring proxy configuration will have their requests fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is needed for our internal dev envs, but go doesn't resolve *.localhost to 127.0.0.1 like browsers and curl does